Skip to content

Make Error fields generated#1845

Merged
xavdid merged 1 commit into
masterfrom
RUN_DEVSDK-2568
Jul 10, 2026
Merged

Make Error fields generated#1845
xavdid merged 1 commit into
masterfrom
RUN_DEVSDK-2568

Conversation

@xavdid

@xavdid xavdid commented Jul 10, 2026

Copy link
Copy Markdown
Member

Why?

Our main API Error class has always been handwritten. As new fields have been added to api_errors in the spec over time (e.g. advice_code, network_advice_code, network_decline_code), we haven't picked them up in the SDKs.

This makes most of those properties generated so they stay in sync.

What?

  • Makes the fields on the API error object generated from the OpenAPI spec
  • Adds section markers so codegen can maintain these fields going forward
  • add tests

See Also

@xavdid
xavdid marked this pull request as ready for review July 10, 2026 20:16
@xavdid
xavdid requested a review from a team as a code owner July 10, 2026 20:16
@xavdid
xavdid requested review from jar-stripe and removed request for a team July 10, 2026 20:16
@xavdid
xavdid enabled auto-merge (squash) July 10, 2026 20:16
@xavdid
xavdid merged commit 76ffa83 into master Jul 10, 2026
17 checks passed
@xavdid
xavdid deleted the RUN_DEVSDK-2568 branch July 10, 2026 21:50
xavdid added a commit that referenced this pull request Jul 17, 2026
* Update generated code (#1836)

* Update generated code for v2323 and 1f0a7866ce5b5e12153c09a04349f91486b17d95

* Update generated code for v2324 and 6012b623b1c09ad54d466947da04511a042ee45a

---------

Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>

* Bump version to 15.3.0

* Reduce StripeClient() cold start latency for serverless environments (#1834)

* Remove unused Retry-After header support (#1843)

* make api error fields generated (#1845)

* move publish job to trusted publishing (#1847)

* move to trusted publishing

* Replace source hash with Telemetry UUID (#1846)

* Replace source hash with telemetry UUID

* minor tweaks

* Add/adjust tests & CI

* Bump version to 15.3.1

* use ip address directly instead of localhost for faster windows tests (#1849)

---------

Co-authored-by: stripe-openapi[bot] <105521251+stripe-openapi[bot]@users.noreply.github.com>
Co-authored-by: jar-stripe <jar@stripe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants